Add StatusCode to understand where we are in the game #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faskowbn
commented
May 16, 2024
| /// </summary> | ||
| /// <param name="statusCode">The status code string.</param> | ||
| /// <returns>The corresponding GameStatus enum value, or null if the status code is unknown.</returns> | ||
| public static GameStatus? GetStatusCode(string? statusCode) |
There was a problem hiding this comment.
I thought about adding a Utils folder for functions like this, but I didn't want to encroach on the existing folder structure. I'm happy to put this function wherever.
|
Hi @brfaskow looks good to me! I'm merging this PR now. I'll try to have a Nuget build up within the next few days. |
|
Awesome! Please let me know when a new nuget package version is pushed.
Best,
Brad
…On Fri, May 17, 2024 at 9:21 PM Mark-James M ***@***.***> wrote:
Merged #21 <#21> into
master.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU6ZMIRXCA3AMTOPVLIE4RTZC2UKTAVCNFSM6AAAAABHIAJBNGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA2TIMRXGY4TQMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "StatusCode" to the
Schedulemodel, piping in data we already get in the Schedule DTO. I'd like to use it in my project downstream.I also add a
GameStatusenum. Unfortunately, I don't have access to the MLB documentation, so I'm not quite sure if I'm capturing all potential game statuses -- I feel like I at least captured most of them. If we see an unfamiliar status, I just return null.I thought about calling "StatusCode" "GameStatusCode", but I figured that it is clear enough we are already in the "Game" context.
Tested with the console app:
